Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 )
Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot ...................................................................... Patch Set 6: (11 comments) Looks good, left some minor comments. http://gerrit.cloudera.org:8080/#/c/21605/6/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/21605/6/fe/pom.xml@446 PS6, Line 446: <version>6.0.0</version> It could be externalized similarly as Iceberg. http://gerrit.cloudera.org:8080/#/c/21605/6/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java File fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java: http://gerrit.cloudera.org:8080/#/c/21605/6/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@23 PS6, Line 23: import java.util.Iterator; unused import http://gerrit.cloudera.org:8080/#/c/21605/6/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@33 PS6, Line 33: import org.apache.hadoop.hive.metastore.api.ColumnStatisticsObj; unused import http://gerrit.cloudera.org:8080/#/c/21605/6/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@166 PS6, Line 166: LOG.warn("Multiple NDV values from Puffin statistics for column '" + col.getName() It could be a format string. http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/pom.xml File java/puffin-data-generator/pom.xml: http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/pom.xml@1 PS6, Line 1: <?xml version="1.0"?> nit: this project could be added as a module to the parent pom http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/pom.xml@30 PS6, Line 30: <artifactId>impala-data-generator</artifactId> Ther artifactId clashes with datagenerator subproject http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/pom.xml@77 PS6, Line 77: <version>6.0.0</version> See comment on fe/pom.xml:446 http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java File java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java: http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java@18 PS6, Line 18: package org.apache.impala.puffin_data_generator; nit: package names are looking better without underscores http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java@35 PS6, Line 35: import java.util.Map; unused imports on L41, L43-45, L47 http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java@131 PS6, Line 131: generator.writeFileWithAllStats(0); sequneceNumber is always 0, it can be omitted. http://gerrit.cloudera.org:8080/#/c/21605/6/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java@396 PS6, Line 396: throws FileNotFoundException, UnsupportedEncodingException, IOException is more general, FileNotFoundException and UnsupportedEncodingException is not needed -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2024 13:03:58 +0000 Gerrit-HasComments: Yes
