Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 )
Change subject: WIP - IMPALA-13247: Support Reading Puffin files for the current snapshot ...................................................................... Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/21605/3/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java File fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java: http://gerrit.cloudera.org:8080/#/c/21605/3/fe/src/main/java/org/apache/impala/catalog/PuffinStatsLoader.java@177 PS3, Line 177: if (byteBuffer.hasArray() && byteBuffer.arrayOffset() == 0 && byteBuffer.position() == 0) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21605/3/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java File java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java: http://gerrit.cloudera.org:8080/#/c/21605/3/java/puffin-data-generator/src/main/java/org/apache/impala/puffin_data_generator/PuffinDataGenerator.java@233 PS3, Line 233: // There are duplicate stats for some column(s) in separate Puffin files. The first value line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1794 PS3, Line 1794: class TestIcebergTableWithPuffinStats(IcebergTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1822 PS3, Line 1822: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1862 PS3, Line 1862: a flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1871 PS3, Line 1871: / flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1875 PS3, Line 1875: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1879 PS3, Line 1879: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1883 PS3, Line 1883: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1887 PS3, Line 1887: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1891 PS3, Line 1891: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1895 PS3, Line 1895: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/21605/3/tests/query_test/test_iceberg.py@1899 PS3, Line 1899: flake8: E202 whitespace before ')' -- To view, visit http://gerrit.cloudera.org:8080/21605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50c1228988960a686d08a9b2942e01e366678866 Gerrit-Change-Number: 21605 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2024 15:45:51 +0000 Gerrit-HasComments: Yes
