Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21646 )
Change subject: IMPALA-13240: Add gerrit comments for Thrift/FlatBuffers changes ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21646/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21646/3//COMMIT_MSG@17 PS3, Line 17: Add a new option for critique-gerrit-review.py to specify the commit. nit: Add example on how to run the script in local machine. http://gerrit.cloudera.org:8080/#/c/21646/3/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/21646/3/bin/jenkins/critique-gerrit-review.py@353 PS3, Line 353: parser.add_argument("-c", "--commit", default="HEAD", : help="The commit to check. Defaults to HEAD") Can we add argument so we can compare two non-consecutive hash? Maybe another one to skip flake8 as well, considering comment in L358. -- To view, visit http://gerrit.cloudera.org:8080/21646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib35fafa50bfd38631312d22464df14d426f55346 Gerrit-Change-Number: 21646 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 15:31:34 +0000 Gerrit-HasComments: Yes
