Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21646
Change subject: Test commit ...................................................................... Test commit Adds gerrit comments for changes in Thrift/FlatBuffers files that could break the communication between impalad and catalogd/statestore during upgrade. Basically, only new optional fields can be added in Thrift protocol. For Flatbuffers schemas, we should only add new fields at the end of a table definition. Add a new option for critique-gerrit-review.py to specify the commit. Tested with incompatible commits like 012996a06 and 65094a74f. Change-Id: Ib35fafa50bfd38631312d22464df14d426f55346 --- M bin/jenkins/critique-gerrit-review.py M common/fbs/CatalogObjects.fbs M common/thrift/CatalogObjects.thrift 3 files changed, 143 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/21646/1 -- To view, visit http://gerrit.cloudera.org:8080/21646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib35fafa50bfd38631312d22464df14d426f55346 Gerrit-Change-Number: 21646 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]>
