Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21587 )
Change subject: IMPALA-13115: Add query id to error messages ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/21587/12/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/21587/12/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@211 PS12, Line 211: assertEquals(cancelResp.getStatus().getErrorMessage().contains(expectedError), true); nit: use assertTrue() assertTrue(cancelResp.getStatus().getErrorMessage().contains(expectedError)); http://gerrit.cloudera.org:8080/#/c/21587/12/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/21587/12/tests/common/test_result_verifier.py@821 PS12, Line 821: a query id is available, e.g. "Invalid session id" and "Unsupported operation". Do we still add the string of "Query xxx failed" in such errors? -- To view, visit http://gerrit.cloudera.org:8080/21587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67e659681e36162cad1d9684189106f8eedbf092 Gerrit-Change-Number: 21587 Gerrit-PatchSet: 12 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 08:25:43 +0000 Gerrit-HasComments: Yes
