Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21587 )
Change subject: IMPALA-13115: Add query id to error messages ...................................................................... Patch Set 9: Code-Review+2 (2 comments) Carry Michael's +1. Nice work! http://gerrit.cloudera.org:8080/#/c/21587/8/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/21587/8/tests/beeswax/impala_beeswax.py@62 PS8, Line 62: return self.__message > Yes. Otherwise `error_msg_expected()` will always return `False` since the Ack http://gerrit.cloudera.org:8080/#/c/21587/8/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/21587/8/tests/common/test_result_verifier.py@827 PS8, Line 827: return actual_msg.find(expected_msg, m.end()) != -1 > Thanks! I tested locally and found that if there is an error, pytest will d Ack -- To view, visit http://gerrit.cloudera.org:8080/21587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67e659681e36162cad1d9684189106f8eedbf092 Gerrit-Change-Number: 21587 Gerrit-PatchSet: 9 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 00:07:02 +0000 Gerrit-HasComments: Yes
