Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 )
Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' ...................................................................... Patch Set 3: (2 comments) Thanks for adding the clarification! http://gerrit.cloudera.org:8080/#/c/21644/3/docs/topics/impala_runtime_filter_wait_time_ms.xml File docs/topics/impala_runtime_filter_wait_time_ms.xml: http://gerrit.cloudera.org:8080/#/c/21644/3/docs/topics/impala_runtime_filter_wait_time_ms.xml@43 PS3, Line 43: Note that the wait time for a runtime filter is with respect to the beginning of Can you also add this to the comment of the query option? https://github.com/apache/impala/blob/5b7ed40d52bb63a5dda0f12f83370b0fbcaaca26/common/thrift/Query.thrift#L243 That is where I usually look for the semantics of query option. http://gerrit.cloudera.org:8080/#/c/21644/3/docs/topics/impala_runtime_filter_wait_time_ms.xml@44 PS3, Line 44: Prepare phase AFAIK it starts even earlier, in QueryState:Init().Maybe it could be phrased as "is with respect to the start of processing the query in the given executor instead Open phase of the scan node" -- To view, visit http://gerrit.cloudera.org:8080/21644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98e23a902a65e4fa41a628d4a3edb1894660fb4 Gerrit-Change-Number: 21644 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2024 08:06:25 +0000 Gerrit-HasComments: Yes
