Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21644 )

Change subject: IMPALA-13276: Revise the documentation of 
'RUNTIME_FILTER_WAIT_TIME_MS'
......................................................................


Patch Set 3:

(1 comment)

Hi all, let me know if there is any other suggestion. Thanks a lot for the help!

http://gerrit.cloudera.org:8080/#/c/21644/2/docs/topics/impala_runtime_filter_wait_time_ms.xml
File docs/topics/impala_runtime_filter_wait_time_ms.xml:

http://gerrit.cloudera.org:8080/#/c/21644/2/docs/topics/impala_runtime_filter_wait_time_ms.xml@43
PS2, Line 43: Note that the wait time for a runtime filter is with respect to 
the beginning of
            :       the Prepare phase instead of the beginning of the Open 
phase of a scan node. For
            :       instance, a scan node could start so late that at th
> This sounds too detail for user that has not see the code. I'd like to offe
Thanks Riza! I will revise the patch accordingly in the next patch set.



--
To view, visit http://gerrit.cloudera.org:8080/21644
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic98e23a902a65e4fa41a628d4a3edb1894660fb4
Gerrit-Change-Number: 21644
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 06 Aug 2024 00:25:01 +0000
Gerrit-HasComments: Yes

Reply via email to