Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/21541/3/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/21541/3/be/src/exec/hdfs-scan-node-base.h@826 PS3, Line 826: scan rang > nit. scan range Done http://gerrit.cloudera.org:8080/#/c/21541/3/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/21541/3/common/thrift/PlanNodes.thrift@354 PS3, Line 354: scan rang > nit. scan range Done http://gerrit.cloudera.org:8080/#/c/21541/3/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java File fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java: http://gerrit.cloudera.org:8080/#/c/21541/3/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java@115 PS3, Line 115: output.append(detailPrefix + "cache key: " + compileTimeKey_ + "\n"); > Should be better to use append. For code that isn't performance sensitive, I think we should optimize for readability. I prefer the simpler + syntax or String.format() unless we really need the performance. http://gerrit.cloudera.org:8080/#/c/21541/3/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java@124 PS3, Line 124: output.append(detailPrefix + "[" + hashTrace_.substring(idx, stop_idx) + "]\n"); > It seems that using append would be better than using the '+', as '+' creat Same as other location. http://gerrit.cloudera.org:8080/#/c/21541/3/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java@128 PS3, Line 128: output.append(detailPrefix + "input scan node ids: " + : String.join(",", input_scan_node_ids_strs) + "\n"); > Should be better to use append. Same as other location. -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:28:08 +0000 Gerrit-HasComments: Yes
