Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/21541/2/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/21541/2/be/src/exec/hdfs-scan-node-base.cc@488 PS2, Line 488: deterministic_scanrange_assignment_(hdfs_scan_node.deterministic_scanrange_assignment), > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/21541/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/21541/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1959 PS2, Line 1959: // There reason we skip setting the deterministic scan range assignment field for > nit: "The" not "There" Done http://gerrit.cloudera.org:8080/#/c/21541/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2065 PS2, Line 2065: // To avoid polluting the explain output, only add this if this is mt_dop>0 and > nit: "this" is used in two different ways here. I'd shorten it to "only add Done http://gerrit.cloudera.org:8080/#/c/21541/2/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/21541/2/tests/custom_cluster/test_tuple_cache.py@88 PS2, Line 88: # Get cache metrics from all impalads > This comment seems wrong, it's just getting it from a single impalad. Right, this is just one impalad. Fixed. http://gerrit.cloudera.org:8080/#/c/21541/2/tests/custom_cluster/test_tuple_cache.py@307 PS2, Line 307: " > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/21541/2/tests/custom_cluster/test_tuple_cache.py@313 PS2, Line 313: " > flake8: E501 line too long (92 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 29 Jun 2024 00:05:15 +0000 Gerrit-HasComments: Yes
