Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 1: (27 comments) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/common/global-flags.cc@357 PS1, Line 357: "However, a small value of larger than 1 may limit the parallelism of FE requests when " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1332 PS1, Line 1332: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->agg_current_users->ToHumanReadable()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1333 PS1, Line 1333: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->local_current_users->ToHumanReadable()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1340 PS1, Line 1340: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->agg_current_users->ToHumanReadable()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1341 PS1, Line 1341: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->local_current_users->ToHumanReadable()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1348 PS1, Line 1348: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->agg_current_users->ToHumanReadable()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1349 PS1, Line 1349: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->local_current_users->ToHumanReadable()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1370 PS1, Line 1370: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->agg_current_users->ToHumanReadable()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller-test.cc@1371 PS1, Line 1371: ASSERT_EQ("[" + USER1 + "]", pool_stats->metrics()->local_current_users->ToHumanReadable()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.h@182 PS1, Line 182: /// group ‘workers’ (which group includes ‘sunil’), and if a query is submitted by sunil, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.h@210 PS1, Line 210: /// - ReleaseQueryBackends rpc fails: when ReleaseQuery is eventually called (as guaranteed line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.h@1284 PS1, Line 1284: static bool HasSufficientGroupQuota(const TPoolConfig& pool_cfg, const string& pool_name, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.cc@2316 PS1, Line 2316: if (!admit_from_queue && !CanAdmitQuota(*state, pool_config, root_cfg, &rejection_reason)) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.cc@2772 PS1, Line 2772: Value agg_users(metrics_.agg_current_users->ToHumanReadable().c_str(), document->GetAllocator()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/scheduling/admission-controller.cc@2775 PS1, Line 2775: Value local_users(metrics_.local_current_users->ToHumanReadable().c_str(), document->GetAllocator()); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/util/collection-metrics.h File be/src/util/collection-metrics.h: http://gerrit.cloudera.org:8080/#/c/21616/1/be/src/util/collection-metrics.h@52 PS1, Line 52: return metrics->RegisterMetric(new SetMetric(MetricDefs::Get(key, metric_def_arg), value)); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/main/java/org/apache/impala/service/BackendConfig.java@537 PS1, Line 537: public String getInjectedGroupMembersDebugOnly() {return backendCfg_.injected_group_members_debug_only;} line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java File fe/src/main/java/org/apache/impala/util/RequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@375 PS1, Line 375: Map<String, Integer> groupQueryLimits = allocationConf_.get().getGroupQueryLimits(pool); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@34 PS1, Line 34: import org.apache.impala.yarn.server.resourcemanager.scheduler.fair.AllocationConfigurationException; line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@35 PS1, Line 35: import org.apache.impala.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@360 PS1, Line 360: checkPoolConfigResult("root", -1, 200, -1, null, "", rootQueryLimits, rootGroupLimits); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@443 PS1, Line 443: checkPoolConfigResult("root", 15, 100, -1, 30000L, "", rootQueryLimits, rootGroupLimits); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@479 PS1, Line 479: expectedResult.setUser_query_limits(userQueryLimits != null ? userQueryLimits:Collections.emptyMap()); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@480 PS1, Line 480: expectedResult.setGroup_query_limits(groupQueryLimits != null ? groupQueryLimits: Collections.emptyMap()); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21616/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/21616/1/tests/custom_cluster/test_admission_controller.py@1224 PS1, Line 1224: o flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21616/1/tests/custom_cluster/test_admission_controller.py@1225 PS1, Line 1225: = flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21616/1/tests/custom_cluster/test_admission_controller.py@1272 PS1, Line 1272: l flake8: E501 line too long (98 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2024 23:45:53 +0000 Gerrit-HasComments: Yes
