Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding ...................................................................... Patch Set 6: (3 comments) Nice patch Myktybek, I left some nits. http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py File tests/query_test/test_parquet_encodings.py: http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py@16 PS6, Line 16: # under the License. nit: add spacing between license and imports http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py@43 PS6, Line 43: def byte_stream_split_helper(self, vector, unique_database, file_name, column_def): nit: we usually prefix helper functions with underscore (_) http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py@46 PS6, Line 46: unique_database + "." + table_name it could be extracted, or table_name could be formatted with unique_database, like `table_name = "{}.{}".format(unique_database, "test_table")` -- To view, visit http://gerrit.cloudera.org:8080/21591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73 Gerrit-Change-Number: 21591 Gerrit-PatchSet: 6 Gerrit-Owner: Myktybek Sattarov <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 18 Jul 2024 08:46:48 +0000 Gerrit-HasComments: Yes
