Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21591 )

Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split 
encoding
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py
File tests/query_test/test_parquet_encodings.py:

http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@21
PS2, Line 21: class TestParquetEncodings(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@31
PS2, Line 31:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@31
PS2, Line 31:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@33
PS2, Line 33: _
flake8: E501 line too long (137 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@36
PS2, Line 36: _
flake8: E501 line too long (139 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@40
PS2, Line 40: +
flake8: E501 line too long (115 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@43
PS2, Line 43: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@43
PS2, Line 43: i
flake8: E501 line too long (124 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@45
PS2, Line 45:
flake8: W292 no newline at end of file



--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 2
Gerrit-Owner: Myktybek Sattarov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jul 2024 13:37:31 +0000
Gerrit-HasComments: Yes

Reply via email to