Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 )
Change subject: IMPALA-13194: Fast-serialize position delete records ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/row-batch.cc@266 PS2, Line 266: RETURN_IF_ERROR(output_batch->Finalize(row_desc_->tuple_descriptors().size(), optional: I think that it would be useful to move Finalize (and compression) outside of Serialize() two reasons: - the signature of Serialize() could be simpler by not having compression related arguments - a separate timer could be added for compression to KrpcDataSender - currently serialize_batch_timer_ contains both serialization and compression, so it is not evident from the profile which one takes more time -- To view, visit http://gerrit.cloudera.org:8080/21563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6095f318e3d06dedb4197681156b40dd2a326c6f Gerrit-Change-Number: 21563 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 05:30:58 +0000 Gerrit-HasComments: Yes
