Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 )
Change subject: IMPALA-13194: Fast-serialize position delete records ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc@760 PS1, Line 760: Can you add some comments about the role of this class? Also, I think that it would be better to move some of the logic to another class (e.g. PositionDeleteCollector) and file - KrpcDataStreamSender is already too large/complex. http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc@855 PS1, Line 855: bool compress = channel_->IsLocal(); It should compress if the channel is not local. http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/row-batch.cc@272 PS1, Line 272: RETURN_IF_ERROR(output_batch->TryCompress(compression_scratch, is_compressed)); +1 for moving these to another outbound-row-batch.cc -- To view, visit http://gerrit.cloudera.org:8080/21563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6095f318e3d06dedb4197681156b40dd2a326c6f Gerrit-Change-Number: 21563 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2024 11:47:21 +0000 Gerrit-HasComments: Yes
