Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 )
Change subject: IMPALA-12370: allow converting timestamps to UTC when writing Kudu ...................................................................... Patch Set 3: Code-Review+1 (4 comments) LGTM. Just a couple of nits. Note: It is important to set the right query option when impala is being used along with other applications (e.g. standalone java application) that may be following its own convention for conversion. http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@7 PS3, Line 7: allow nit: Allow http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@7 PS3, Line 7: writing nit: writing to http://gerrit.cloudera.org:8080/#/c/21492/3//COMMIT_MSG@9 PS3, Line 9: commit nit: commit, http://gerrit.cloudera.org:8080/#/c/21492/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/21492/2/common/thrift/ImpalaService.thrift@946 PS2, Line 946: // written to Kudu as UNI > I agree that the current names are not too good, but "CONVERT_KUDU_UTC_TIME Thanks for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/21492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4995a64e042e7bb261fcc6e6bf7ffce61e9bd1 Gerrit-Change-Number: 21492 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 11 Jun 2024 12:58:14 +0000 Gerrit-HasComments: Yes
