Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 )
Change subject: WIP: IMPALA-12370: allow converting timestamps to UTC when writing Kudu ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21492/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21492/2//COMMIT_MSG@16 PS2, Line 16: To be able to read back Kudu tables written by Impala correctly : convert_kudu_utc_timestamps and write_kudu_utc_timestamps need to : have the same value. > This leads to an obvious question: why to introduce an extra option --write +1 http://gerrit.cloudera.org:8080/#/c/21492/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/21492/2/common/thrift/ImpalaService.thrift@946 PS2, Line 946: WRITE_KUDU_UTC_TIMESTAMPS Make both the query names similar. For read, it starts with CONVERT_ and for write it is simply WRITE_ Would be more uniformity in names, if it looks something like of these options: READ_CONVERT_KUDU_UTC_TIMESTAMPS / WRITE_CONVERT_KUDU_UTC_TIMESTAMPS OR READ_KUDU_UTC_TIMESTAMPS / WRITE_KUDU_UTC_TIMESTAMPS or anything you seem fit where naming convention is uniform. -- To view, visit http://gerrit.cloudera.org:8080/21492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4995a64e042e7bb261fcc6e6bf7ffce61e9bd1 Gerrit-Change-Number: 21492 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2024 08:58:35 +0000 Gerrit-HasComments: Yes
