Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/21131/11/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/11/be/src/util/coding-util.cc@51 PS11, Line 51: '\x20' > For those characters that have a readable literal representation, e.g. " ", Why adding space character here? Hive doesn't escape it in partition paths. E.g. beeline -u "jdbc:hive2://localhost:11050" hive> create table my_part_tbl(i int) partitioned by (p string); hive> alter table my_part_tbl add partition(p='a b'); hive> show partitions my_part_tbl; +------------+ | partition | +------------+ | p=a b | +------------+ hive> describe formatted my_part_tbl partition(p='a b'); ... | Location: | hdfs://localhost:20500/test-warehouse/my_part_tbl/p=a b | NULL | ... http://gerrit.cloudera.org:8080/#/c/21131/11/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: http://gerrit.cloudera.org:8080/#/c/21131/11/testdata/workloads/functional-query/queries/QueryTest/insert.test@450 PS11, Line 450: '' We just need double single quotes in the RESULTS section to escape a single quote. Don't need to do this in the QUERY section. http://gerrit.cloudera.org:8080/#/c/21131/11/testdata/workloads/functional-query/queries/QueryTest/insert.test@452 PS11, Line 452: RAW_STRING I don't think need this. It's used for non-ascii characters. http://gerrit.cloudera.org:8080/#/c/21131/11/testdata/workloads/functional-query/queries/QueryTest/insert.test@470 PS11, Line 470: This will fail if we escape space. -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 11 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2024 01:47:05 +0000 Gerrit-HasComments: Yes
