[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 11: (5 comments) > Patch Set 11: > > (2 comments) http://gerrit.cloudera.org:8080/#/c/21131/10/be/src/util/coding-util-test.cc File be/src/util/coding-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21131/10/be/src/util/coding-util-test.cc@94 PS10, Line 94: TestUrl("/home/impala/directory/", "%2Fhome%2Fimpala%2Fdirectory%2F", false); : TestUrl("/home/impala/directory/", "%2Fhome%2Fimpala%2Fdirectory%2F", true); > Please add some tests like these for newly added marks like '\n', '\r', '^' Done http://gerrit.cloudera.org:8080/#/c/21131/10/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/10/be/src/util/coding-util.cc@a40 PS10, Line 40: : : : > Can you keep this comment? We should still mention common/src/java/org/apac Done http://gerrit.cloudera.org:8080/#/c/21131/10/be/src/util/coding-util.cc@45 PS10, Line 45: // characters it will encode. : // See common/src/java/org/apache/hadoop/hive/common > We are still missing several characters here, e.g. single quote, '\n' and ' Done http://gerrit.cloudera.org:8080/#/c/21131/11/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/11/be/src/util/coding-util.cc@51 PS11, Line 51: '\x20' Represents space character http://gerrit.cloudera.org:8080/#/c/21131/10/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: http://gerrit.cloudera.org:8080/#/c/21131/10/testdata/workloads/functional-query/queries/QueryTest/insert.test@452 PS10, Line 452: ---- RESULTS: RAW_STRING : '0','O''Reilly' : ---- TYPES : STRING, STRING : ==== : ---- QUERY : truncate insert_string_partitioned; : INSERT INTO TABLE insert_string_partitioned PARTITION(s2="Impala''#%*/:=?{}[]^") values ('0'); : SELECT * FROM insert_string_partitioned where s2= "Impala''#%*/:=?{}[]^"; : ---- RESULTS: RAW_STRING : '0','Impala''#%*/:=?{}[]^' : ---- TYPES > e2e tests for ASCII characters can be added here, e.g. Done -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 11 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 29 Apr 2024 11:43:36 +0000 Gerrit-HasComments: Yes
