Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 )
Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG@26 PS11, Line 26: square-root-based Update to "nth root based" or something similar to be more accurate? http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG@35 PS11, Line 35: field plural - 'fields'? This is referring to fragment level parallelism, right? http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG@36 PS11, Line 36: The CpuAsk : counter is changed to show the unbounded CpuAsk after scaling. A new : counter CpuAskBounded shows the bounded CpuAsk after scaling. The : EffectiveParallelism counter remains unchanged, showing bounded CpuAsk : before scaling. This is a little confusing. The Fragment instance count are still based on CpuAsk - bounded or unbounded and before or after scaling? Trying to figure what we use for computing admission_slots. http://gerrit.cloudera.org:8080/#/c/21277/11/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/21277/11/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@85 PS11, Line 85: topNode = fragment.getPlanRoot(); topNode not really being used? -- To view, visit http://gerrit.cloudera.org:8080/21277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5441e31088f90761062af35862be4ce09d116923 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 20:12:58 +0000 Gerrit-HasComments: Yes
