Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 )
Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/21277/10/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/21277/10/be/src/util/backend-gflag-util.cc@266 PS10, Line 266: 1.5 > I think we should use a default value of 1.5 here. Using 2.0 (the actual sq Done http://gerrit.cloudera.org:8080/#/c/21277/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21277/10/fe/src/main/java/org/apache/impala/service/Frontend.java@2322 PS10, Line 2322: scaledCoreReqToCompare = Math.max(scaledCpuAskBounded, scaledCpuAskUnbounded); > I'm a little concerned that using the max here will allow the EG size to ex Yes, this will require bigger change along adjustToMaxParallelism() and traverseEffectiveParallelism(). cpuAskUnbounded here is the greedy number to encourage EG promotion. On the other hand, cpuAskBounded is the hard requirement that Frontend should adhere to, because it is what will actually run. We should think about how to do sublinear scaling of cpuAskBounded during planning in separate patch. http://gerrit.cloudera.org:8080/#/c/21277/10/fe/src/main/java/org/apache/impala/service/Frontend.java@2442 PS10, Line 2442: nthRootSmallestEGTotalCo > Maybe call this nthrootSmallestEGTotalCores Done -- To view, visit http://gerrit.cloudera.org:8080/21277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5441e31088f90761062af35862be4ce09d116923 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 16:45:46 +0000 Gerrit-HasComments: Yes
