Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21294 )
Change subject: IMPALA-12874: Identify active and standby catalog and statestore in the web debug endpoint ...................................................................... Patch Set 3: (3 comments) Thanks for the review. This patch fixes previous feedbacks, and combines the logic of adding status to a function AddActiveStatus() in default-path-handlers.cc. http://gerrit.cloudera.org:8080/#/c/21294/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21294/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12874: Identify active and standby catalog and statestore in the web debug endpoint > Incomplete sentence: Done http://gerrit.cloudera.org:8080/#/c/21294/2//COMMIT_MSG@20 PS2, Line 20: Manually tests the web page, and verified the status display is : correct. > If there is a failover does the status get updated? Can we also test that? Tested and worked. Added in the commit message. http://gerrit.cloudera.org:8080/#/c/21294/2/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/21294/2/be/src/util/default-path-handlers.cc@271 PS2, Line 271: > admissiond also uses DaemonEnv, we should handle that case also. Maybe exit Done -- To view, visit http://gerrit.cloudera.org:8080/21294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9435ba7a9549ea56f9d080a9315aecbcc630cd2 Gerrit-Change-Number: 21294 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2024 18:18:03 +0000 Gerrit-HasComments: Yes
