Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21294 )
Change subject: IMPALA-12874: Identify active and standby catalog and statestore the web debug endpoint ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21294/1//COMMIT_MSG@15 PS1, Line 15: active as : the status nit: status as active http://gerrit.cloudera.org:8080/#/c/21294/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/21294/1/be/src/util/default-path-handlers.cc@283 PS1, Line 283: if (metric->GetValue()) { : document->AddMember( : "catalogd_active_status", "Active", document->GetAllocator()); : } else { : document->AddMember( : "catalogd_active_status", "Standby", document->GetAllocator()); : } nit: this can be simplified as document->AddMember("catalogd_active_status", (metric->GetValue() ? "Active" : "Standby"), document->GetAllocator()); -- To view, visit http://gerrit.cloudera.org:8080/21294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9435ba7a9549ea56f9d080a9315aecbcc630cd2 Gerrit-Change-Number: 21294 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 12 Apr 2024 16:36:13 +0000 Gerrit-HasComments: Yes
