Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21039 )
Change subject: IMPALA-12786: Optimize count(*) for JSON scans ...................................................................... Patch Set 9: (1 comment) Thank you again for the review. http://gerrit.cloudera.org:8080/#/c/21039/9/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/21039/9/be/src/service/query-options.h@329 PS9, Line 329: QUERY_OPT_FN(disable_optimized_json_count_star, DISABLE_OPTIMIZED_JSON_COUNT_STAR, \ : TQueryOptionLevel::ADVANCED) > nit: JSON scanner looks pretty new and probably not widely used yet. I don' I am inclined to keep this query option for now, as it is very likely that we will further expand the features of the json scanner in the future. Keeping this query option will help us to more conveniently test to ensure consistent optimization results. -- To view, visit http://gerrit.cloudera.org:8080/21039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97ff097661c3c577aeafeeb1518408ce7a8a255e Gerrit-Change-Number: 21039 Gerrit-PatchSet: 9 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 06:20:23 +0000 Gerrit-HasComments: Yes
