Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21039 )
Change subject: IMPALA-12786: Optimize count(*) for JSON scans ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Looks good to me. Lets wait for feedback from other reviewers. http://gerrit.cloudera.org:8080/#/c/21039/9/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/21039/9/be/src/service/query-options.h@329 PS9, Line 329: QUERY_OPT_FN(disable_optimized_json_count_star, DISABLE_OPTIMIZED_JSON_COUNT_STAR, \ : TQueryOptionLevel::ADVANCED) nit: JSON scanner looks pretty new and probably not widely used yet. I don't mind making this new count star behavior default without query option to control it. -- To view, visit http://gerrit.cloudera.org:8080/21039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97ff097661c3c577aeafeeb1518408ce7a8a255e Gerrit-Change-Number: 21039 Gerrit-PatchSet: 9 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 02 Apr 2024 18:20:19 +0000 Gerrit-HasComments: Yes
