Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21221 )
Change subject: IMPALA-12944: Fixes Workload Management Test Flakiness ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21221/2/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21221/2/tests/custom_cluster/test_query_log.py@64 PS2, Line 64: table sql has finished.""" > You can also extend "def setup_method(self, method)" for TestQueryLogTableB I started down the path of running the `show tables in sys` query but quickly ran into a problem since most of the tests expect a defined number of queries to be executed. Trying to modify each test to handle the variable number of queries that could be executed to verify the completed queries table existed was going to require a large amount of effort. I switched to assert_log_contains after making a modification to it. I wish I could use use setup_method, but I cannot because the cluster has not yet started when that method is called. -- To view, visit http://gerrit.cloudera.org:8080/21221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I428702a210e024db95808dc2518da497426922f8 Gerrit-Change-Number: 21221 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2024 20:43:05 +0000 Gerrit-HasComments: Yes
