Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21221 )
Change subject: IMPALA-12944: Fixes Workload Management Test Flakiness ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21221/2/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21221/2/tests/custom_cluster/test_query_log.py@64 PS2, Line 64: create_re = r'\]\s+(\w+:\w+)\]\s+Analyzing query: CREATE TABLE IF NOT EXISTS {}' \ I thought you might grep the output of `show tables in sys`. If you want to keep the log approach, use assert_log_contains, which retries until reaching a timeout. It also knows where the log dir is, so you don't need all the extra changes. -- To view, visit http://gerrit.cloudera.org:8080/21221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I428702a210e024db95808dc2518da497426922f8 Gerrit-Change-Number: 21221 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2024 18:26:13 +0000 Gerrit-HasComments: Yes
