Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 )
Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. ...................................................................... Patch Set 14: (2 comments) > Patch Set 12: > > (2 comments) > > It looks good, just a minor issue remains. Hi zihao, thanks for pointing these out. I've finished the stop waiting step, at the same time I remove the 'async mode' because it can be replaced by set waiting counts to 0. http://gerrit.cloudera.org:8080/#/c/20921/12/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20921/12/package/bin/impala.sh@93 PS12, Line 93: *) usage && exit 1 ;; > Shouldn't we execute the kill command before this? remove the 'async mode'. http://gerrit.cloudera.org:8080/#/c/20921/12/package/bin/impala.sh@95 PS12, Line 95: done : check_counts ${counts} ${period} : local service_pidfile_key=${service^^}_PIDFILE : local service_pidfile=${!service_pidfile_key} : if [[ ! -f ${service_pidfile} ]]; then : echo "Already stopped: PID file '${service_pidfile}' not found." : exit 0 : fi : local pid=$(cat ${service_pidfile}) : if ! ps -p ${pid} -o comm=|grep ${service} &> /dev/null ; then > nit: I think it would be better to separate this piece of logic into a func Done -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 14 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 16:15:47 +0000 Gerrit-HasComments: Yes
