Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 )
Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. ...................................................................... Patch Set 10: (2 comments) > Patch Set 10: > > (2 comments) > > Very useful feature, thanks for working on this! Hi zihao, thanks for your review! Your advice is useful, and that was the next step I wanted to do in the following commits, but it looks like I have to move my plans up now. I've redesigned the command format and add waiting logic to 'start' and 'stop' command by default. Looking forward to more great suggestions from you! http://gerrit.cloudera.org:8080/#/c/20921/10/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20921/10/package/bin/impala.sh@67 PS10, Line 67: kill $pid > It would be better if we had a 'wait_for_stop' called here to ensure that t Done http://gerrit.cloudera.org:8080/#/c/20921/10/package/bin/impala.sh@67 PS10, Line 67: kill $pid > It would be better if we had a 'wait_for_stop' called here to ensure that t Done -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 10 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Sat, 16 Mar 2024 07:35:09 +0000 Gerrit-HasComments: Yes
