Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 )
Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1899 PS8, Line 1899: isTrivialSdPropsChanged Can't this return true when the SD didn't change at all but there are other changes that would warrant a file metadata reload? Or the Sd property won't be set in that case? http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1963 PS8, Line 1963: if (beforeSd != null && afterSd != null) { Is it possible that on is null while the other is not? Shouldn't the function return false in that case? http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1965 PS8, Line 1965: currentSD = normalizeStorageDescriptor(afterSd.deepCopy()); nit: this looks a bit unusual in Impala, can you split it to to two lines? http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1967 PS8, Line 1967: infoLog("Change in table storage descriptor (SD) detected for table {}.{}. " + non-trivial could be added to the log message http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1977 PS8, Line 1977: unsetting I think that it would make the intention of the function clearer to just state that it unsets properties where the change is considered trivial. http://gerrit.cloudera.org:8080/#/c/21019/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1987 PS8, Line 1987: if (!sd.isSetStoredAsSubDirectories()) { Can you add a comment for this? The previous lines just unset the properties, while in this case we want null and 'false' to be considered the same, but 'true' will be considered different. -- To view, visit http://gerrit.cloudera.org:8080/21019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd9a9504bf93d2529dc7accbf436ad83e51d8ac Gerrit-Change-Number: 21019 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:46:57 +0000 Gerrit-HasComments: Yes
