Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 )
Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ...................................................................... Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1922 PS7, Line 1922: infoLog("Change in table schema detected for table {}.{} from {} to {} ", : tblName_, dbName_, beforeCols.get(i).getName() + " (" + : beforeCols.get(i).getType() +")", afterCols.get(i).getName() + " (" + : afterCols.get(i).getType() + "). So file metadata reload can be " + : "skipped."); nit: might be a bit clearer to refactor this infoLog("Change in table schema detected for table {}.{} from {} ({}) " + "to {} ({}). So file metadata reload can be skipped.", tblName_, dbName_, beforeCols.get(i).getName(), beforeCols.get(i).getType(), afterCols.get(i).getName(), afterCols.get(i).getType()); -- To view, visit http://gerrit.cloudera.org:8080/21019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd9a9504bf93d2529dc7accbf436ad83e51d8ac Gerrit-Change-Number: 21019 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2024 12:30:48 +0000 Gerrit-HasComments: Yes
