Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 47: (2 comments) http://gerrit.cloudera.org:8080/#/c/20770/46/be/src/service/workload-management.h File be/src/service/workload-management.h: http://gerrit.cloudera.org:8080/#/c/20770/46/be/src/service/workload-management.h@519 PS46, Line 519: > These all rely on workload-management.h only being included by workload-man The design came out of my naive understanding of how header files worked. I read up header files and what the compiler does when they are included and now have a much better understanding. I refactored to get a clean separation of declarations and definitions. http://gerrit.cloudera.org:8080/#/c/20770/46/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/20770/46/tests/util/workload_management.py@684 PS46, Line 684: assert sql_results.column_labels[index] == PLAN > Since you defined all the variables at the top, it'd make sense to use them Done -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 47 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2024 18:01:19 +0000 Gerrit-HasComments: Yes
