Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 45: (4 comments) http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/impala-server.h@1285 PS43, Line 1285: /// Pass a session secret for validation. > nit: can this be a struct instead of pair? Done http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/workload-management.cc@212 PS43, Line 212: /// Generates the first portion of the DML that inserts records into the completed queries > nit: we're already in workload-management.cc, might make sense to reference Copy-paste error. This variable declaration came from the header file. Fixed. http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/workload-management.cc@470 PS43, Line 470: impala::worklo > nit: Add comment mentioning that this is an attempt increment. I just saw that too while reviewing my code. Fixed. http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py@168 PS41, Line 168: "--shutdown_grace_period_s=10 " : "--shutdown_deadline_s=60", : catalogd_args="--enable_workload_mgmt", : > In that case, please give distinctive comment for each of them. Done -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 45 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2024 15:22:47 +0000 Gerrit-HasComments: Yes
