Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 )
Change subject: IMPALA-12883: Support updating the charge on an entry in the cache ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/lirs-cache.cc@975 PS2, Line 975: // The handle was marked for eviction while resident; will be evicted on release. > Should we avoid calling UpdateMemTracker for this case? I think we do becau Now that I think about it, I think the update of the charge should happen under a lock. We don't know if something else could evict this entry and whether it saw the old value or new value. Maybe the logic should be: 1. Get lock 2. Bail out without updating the charge if this is TOMBSTONE or UNINITIALIZED. The charge shouldn't change for those entries. They aren't counted towards the capacity. 3. Proceed with the PROTECTED/UNPROTECTED cases. -- To view, visit http://gerrit.cloudera.org:8080/21122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34f54fb3a91a77821651c25d8d3bc3a2a3945025 Gerrit-Change-Number: 21122 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2024 19:03:07 +0000 Gerrit-HasComments: Yes
