Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 )
Change subject: IMPALA-12883: Support updating the charge on an entry in the cache ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/cache.h File be/src/util/cache/cache.h: http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/cache.h@96 PS2, Line 96: // this makes it easier to embed this containers. nit: embed in containers http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/cache.h@130 PS2, Line 130: // this makes it easier to embed this containers. nit: embed in containers http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/lirs-cache.cc@975 PS2, Line 975: // The handle was marked for eviction while resident; will be evicted on release. Should we avoid calling UpdateMemTracker for this case? I think we do because the handle references the new charge, and we need to add the delta so that eviction can subtract the new charge correctly. Might be worth adding a comment to clarify that. -- To view, visit http://gerrit.cloudera.org:8080/21122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34f54fb3a91a77821651c25d8d3bc3a2a3945025 Gerrit-Change-Number: 21122 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2024 18:01:58 +0000 Gerrit-HasComments: Yes
