Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21077 )
Change subject: IMPALA-12847: Expose computeScanRangeLocations and computeStats ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Thanks for the patch. A few small comments but changes overall lgtm. http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@218 PS2, Line 218: is nit: 'if' instead of 'is' http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@221 PS2, Line 221: private Can we make this protected to be consistent with partitions_ member veriable. http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@431 PS2, Line 431: getSampledPartitions It would be preferable to name this method such that it reflects it can return either sampled or raw partitions. The current naming gives a first impression of returning only sampled partitions. How about getSampledOrRawPartitions(). http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1161 PS2, Line 1161: If 'sampleParams_' is not null Since this method is no longer checking sampledParams_ itself but relying on other method, you could modify the comment accordingly. -- To view, visit http://gerrit.cloudera.org:8080/21077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia621309c67455bb599f71bec9efc1f67fc085022 Gerrit-Change-Number: 21077 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 28 Feb 2024 01:59:59 +0000 Gerrit-HasComments: Yes
