Hello Aman Sinha, Fang-Yu Rao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21077
to look at the new patch set (#2).
Change subject: IMPALA-12847: Expose computeScanRangeLocations and computeStats
......................................................................
IMPALA-12847: Expose computeScanRangeLocations and computeStats
After IMPALA-12631, HdfsScanNode.computeScanRangeLocations() need check
if countStarSlot_ is null or not to schedule footer range only.
HdfsScanNode.computeScanRangeLocations() is called along with
HdfsScanNode.init() call.
An external frontend that has its own count star slot analysis and
initialization will need to recompute scan range assignment and stats
after HdfsScanNode.init(). Therefore, computeScanRangeLocations() and
computeStats() should be made idempotent after init() and exposed to
subclasses.
This patch decouple countStarSlot_ initialization from
computeScanRangeLocations() and raise access level of
computeScanRangeLocations() from private to protected.
Testing:
- Pass core tests.
Change-Id: Ia621309c67455bb599f71bec9efc1f67fc085022
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
1 file changed, 81 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/21077/2
--
To view, visit http://gerrit.cloudera.org:8080/21077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia621309c67455bb599f71bec9efc1f67fc085022
Gerrit-Change-Number: 21077
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>