Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21016 )

Change subject: IMPALA-12793: Create JDBC table without data source
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:

http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@233
PS4, Line 233:         String propertyValue =
> line too long (94 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@249
PS4, Line 249:           dataSourceName, true);
> line too long (91 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@276
PS4, Line 276:   }
> line too long (95 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@287
PS4, Line 287:             "stored by JDBC. Missing required metadata: %s", 
name_, key));
> line too long (91 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java:

http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java@127
PS4, Line 127:         throw new TableLoadingException(String.format("Failed to 
load table %s " +
> line too long (91 > 90)
Done



--
To view, visit http://gerrit.cloudera.org:8080/21016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I765aa86b430246786ad85ab6857cefaf4332c920
Gerrit-Change-Number: 21016
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Thu, 22 Feb 2024 02:33:24 +0000
Gerrit-HasComments: Yes

Reply via email to