Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21016 )
Change subject: IMPALA-12793: Create JDBC table without data source ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@233 PS4, Line 233: String propertyValue = getTableProperty(msTbl, config.getPropertyName(), null, false); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@249 PS4, Line 249: dataSource_ = new TDataSource(dataSourceName, location, className, apiVersionString); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@276 PS4, Line 276: private String getTableProperty(org.apache.hadoop.hive.metastore.api.Table msTbl, String key, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@287 PS4, Line 287: throw new TableLoadingException(String.format("Failed to load table %s produced " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/21016/4/fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java@127 PS4, Line 127: throw new TableLoadingException(String.format("Failed to load table %s produced " + line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I765aa86b430246786ad85ab6857cefaf4332c920 Gerrit-Change-Number: 21016 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2024 17:02:20 +0000 Gerrit-HasComments: Yes
