Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21038 )

Change subject: IMPALA-12426: New built-in prettyprint functions for bytes and 
duration.
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21038/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21038/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-12426: New built-in prettyprint functions for bytes and 
duration.
> We should have a separate ticket since this is a new feature that can be us
Agree about assigning separate JIRA number for this.


http://gerrit.cloudera.org:8080/#/c/21038/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21038/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-12426: New built-in prettyprint functions for bytes and 
duration.
> nit: shorten to 72 char, ie.:
Done


http://gerrit.cloudera.org:8080/#/c/21038/4//COMMIT_MSG@10
PS4, Line 10:
> nit: nanoseconds
Done



--
To view, visit http://gerrit.cloudera.org:8080/21038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913
Gerrit-Change-Number: 21038
Gerrit-PatchSet: 7
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Comment-Date: Tue, 20 Feb 2024 21:00:25 +0000
Gerrit-HasComments: Yes

Reply via email to