Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 )
Change subject: IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and prettyprint_memory. ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21038/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21038/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and prettyprint_memory. nit: shorten to 72 char, ie.: IMPALA-12426: Adds prettyprint_duration and prettyprint_memory function IMPALA-12426: Adds built-in prettyprint function for duration and memory http://gerrit.cloudera.org:8080/#/c/21038/4//COMMIT_MSG@10 PS4, Line 10: microseconds nit: nanoseconds http://gerrit.cloudera.org:8080/#/c/21038/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/21038/2/be/src/exprs/expr-test.cc@4353 PS2, Line 4353: TestStringValue("prettyprint_duration(1234)", "1.234us"); > Done Done -- To view, visit http://gerrit.cloudera.org:8080/21038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 16 Feb 2024 20:32:11 +0000 Gerrit-HasComments: Yes
