Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20867 )

Change subject: IMPALA-12688: Support JSON profile imports in webUI
......................................................................


Patch Set 7:

(3 comments)

Thank you for incorporating my feedback. I only have 1 comment left.
Otherwise, looks good.

http://gerrit.cloudera.org:8080/#/c/20867/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20867/7//COMMIT_MSG@49
PS7, Line 49: ascending order
This should be sorted in descending order to match the order of Completed 
Queries table.


http://gerrit.cloudera.org:8080/#/c/20867/6/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/20867/6/www/queries.tmpl@281
PS6, Line 281: };
> nit: is there any max limit on number of profiles to import? If yes, please
Done


http://gerrit.cloudera.org:8080/#/c/20867/6/www/queries.tmpl@370
PS6, Line 370: clear_profiles_button.remove();
> nit: Is it possible to sort the table based on start time on load?
Done



--
To view, visit http://gerrit.cloudera.org:8080/20867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife6eb59bf2030fd19fc92aaf134eb51c609e04d0
Gerrit-Change-Number: 20867
Gerrit-PatchSet: 7
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 07 Feb 2024 23:17:20 +0000
Gerrit-HasComments: Yes

Reply via email to