Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20867 )
Change subject: IMPALA-12688: Support JSON profile imports in webUI ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@215 PS2, Line 215: > Done Done http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@216 PS2, Line 216: id="imported_que > Done Done http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@219 PS2, Line 219: nput id="json_profile_chooser" type="file" accept=".json > Done Done http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@264 PS2, Line 264: var db; > If we clear the browser data, then all imported queries are cleared at once Maybe providing "Clear All" button, if table is not empty, is helpful here. If my browser has history that I want to keep, I'd be reluctant to clear clear all browser data. I understand that I can also clear it through Developer Tools menu (in Chrome: More Tools > Developer Tools > Application > Clear site data), but it might be too obscure for most people. http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@378 PS2, Line 378: sertRowVal(row, query.statement); > Done Done http://gerrit.cloudera.org:8080/#/c/20867/6/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/6/www/queries.tmpl@281 PS6, Line 281: for (var i = 0; i < json_profile_chooser.files.length; i++) { nit: is there any max limit on number of profiles to import? If yes, please mention in commit message. http://gerrit.cloudera.org:8080/#/c/20867/6/www/queries.tmpl@370 PS6, Line 370: insertRowVal(row, query.start_time); nit: Is it possible to sort the table based on start time on load? -- To view, visit http://gerrit.cloudera.org:8080/20867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife6eb59bf2030fd19fc92aaf134eb51c609e04d0 Gerrit-Change-Number: 20867 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2024 20:44:14 +0000 Gerrit-HasComments: Yes
