Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )
Change subject: IMPALA-12375: Make DataSource Object persistent ...................................................................... Patch Set 6: Code-Review+1 (4 comments) LGTM. I just have some minor comments. http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@993 PS6, Line 993: false Could you add a comment for why we use false here? The argument name is 'checkReferences' but I'm unclear how to use it. http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1925 PS6, Line 1925: } Can we add a log when all these are done? E.g. "Finished refreshing DataSources. Added 20. Removed 10." http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2512 PS6, Line 2512: else { nit: remove "else {" since the if-branch will always return. http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6250 PS6, Line 6250: function nit: "DataSource" -- To view, visit http://gerrit.cloudera.org:8080/20768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab Gerrit-Change-Number: 20768 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 02 Jan 2024 04:33:36 +0000 Gerrit-HasComments: Yes
