Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )
Change subject: IMPALA-12375: Make DataSource Object persistent ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java File fe/src/main/java/org/apache/impala/catalog/DataSource.java: http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@20 PS4, Line 20: import org.apache.hadoop.hive.metastore.api.DataConnector; This class doesn't exist in Apache Hive 3.1. We need to move some codes into MetastoreShim of CDP Hive in fe/src/compat-hive-3/ Verified by this job: https://jenkins.impala.io/job/all-build-options-ub2004/598 It runs with "export USE_APACHE_HIVE=true". 04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/DataSource.java:[20,44] cannot find symbol 04:18:29 [ERROR] symbol: class DataConnector 04:18:29 [ERROR] location: package org.apache.hadoop.hive.metastore.api 04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/DataSource.java:[75,10] cannot find symbol 04:18:29 [ERROR] symbol: class DataConnector 04:18:29 [ERROR] location: class org.apache.impala.catalog.DataSource 04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/DataSource.java:[85,46] cannot find symbol 04:18:29 [ERROR] symbol: class DataConnector 04:18:29 [ERROR] location: class org.apache.impala.catalog.DataSource 04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:[56,44] cannot find symbol 04:18:29 [ERROR] symbol: class DataConnector 04:18:29 [ERROR] location: package org.apache.hadoop.hive.metastore.api 04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:[71,44] cannot find symbol 04:18:29 [ERROR] symbol: class DataConnector 04:18:29 [ERROR] location: package org.apache.hadoop.hive.metastore.api 04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:[6223,43] cannot find symbol 04:18:29 [ERROR] symbol: class DataConnector 04:18:29 [ERROR] location: package org.apache.hadoop.hive.metastore.api http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@100 PS4, Line 100: else { : return null; : } nit: remove the else-branch and "return null" directly. -- To view, visit http://gerrit.cloudera.org:8080/20768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab Gerrit-Change-Number: 20768 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 30 Dec 2023 04:35:52 +0000 Gerrit-HasComments: Yes
