Hi Christian, Your assumption appears to be correct. I added a file to a subdirectory and then ran, "rbt diff --debug > rbt-diff.log 2>&1" from root. It look like the diff is only showing the one new file. Let me know if you need me to try anything else. The diff file is attached.
Thanks, John On Sunday, January 22, 2017 at 4:15:02 AM UTC-5, Christian Hammond wrote: > > Hi John, > > Sorry, I've been caught up on some other things. > > I believe the source of the problem has to do with posting the change > inside a subdirectory of the repository. While this ideally should work, > something appears broken. I'm wondering if you can attempt a post from the > root of your clone and see if that succeeds for the same change that > otherwise fails. > > Christian > > > On Fri, Jan 20, 2017 at 06:52 John <[email protected] <javascript:>> wrote: > >> Hi Christian, We were wondering if you guys were making any progress on >> this issue. >> >> Thanks, >> John >> >> >> On Thursday, December 22, 2016 at 10:13:42 AM UTC-5, John wrote: >>> >>> Thanks Christian. Review Board is a great tool and we enjoy its ease of >>> use. We look forward to being able to get around this hurdle in the >>> future. Again, let us know if you need anything else from our end. >>> >>> -John >>> >>> >>> On Wednesday, December 21, 2016 at 10:41:20 PM UTC-5, Christian Hammond >>> wrote: >>>> >>>> Thanks, John! We'll try to figure out what's going on. Already seeing a >>>> few things wrong with the diff, which may clue us in to the source of the >>>> problem. We'll try to get this fixed and get back to you after the >>>> holidays. >>>> >>>> Christian >>>> >>>> On Wed, Dec 21, 2016 at 10:52 John <[email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Monday, December 19, 2016 at 5:10:15 PM UTC-5, John wrote: >>>>>> >>>>>> We are using mercurial in our environment and for some reason we are >>>>>> seeing a number of __init__.py (blank files for module inclusion in >>>>>> python) >>>>>> are being added to our diff file. Here is the process we used to >>>>>> reproduce >>>>>> the issue: >>>>>> >>>>>> 1. Clone a branch in the repo. >>>>>> 2. create a new file with some text in it (i.e. mytestfile.py). >>>>>> 3. Add a new file in the repo with "hg add mytestfile.py" >>>>>> 4. hg commit -m "This is a test" ./mytestfile.py >>>>>> 5. rbt post >>>>>> >>>>>> >>>>>> Here is what the diff of the new file looks like with a simple "hg >>>>>> diff" before running commit: >>>>>> >>>>>> diff --git a/python/tools/mytestfile.py b/python/tools/mytestfile.py >>>>>> new file mode 100644 >>>>>> --- /dev/null >>>>>> +++ b/python/mytestfile.py >>>>>> @@ -0,0 +1,1 @@ >>>>>> +print "This is a test" >>>>>> >>>>>> Attached please find the diff that was downloaded from Review Board. >>>>>> >>>>>> What you'll find is that the diff for the new file that was added >>>>>> does make it up there but for some reason ~50+ __init__.py files are >>>>>> also >>>>>> removed and then added to the diff. It causes the review request to >>>>>> look >>>>>> very messy. The diff file I added was downloaded directly from review >>>>>> board and then I snipped the end of it so the file wouldn't be too >>>>>> large. >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> >>>>> >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> >>>>> >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> >>>>> >>>>> --- >>>>> >>>>> >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> >>>>> >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>>> >>>>> >>>> >>>> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
>>> RBTools 0.7.4 >>> Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609] >>> Running on Linux-4.4.0-59-generic-x86_64-with-Ubuntu-16.04-xenial >>> Home = /home/jlacroix >>> Current directory = /home/jlacroix/bin/repos/unity2 >>> Running: git version >>> Checking for a Subversion repository... >>> Unable to execute "svn help": skipping SVN >>> Checking for a Git repository... >>> Running: git rev-parse --git-dir >>> Command exited with rc 128: ['git', 'rev-parse', '--git-dir'] fatal: Not a git repository (or any of the parent directories): .git --- >>> Checking for a Mercurial repository... >>> Running: hg root >>> Running: hg showconfig >>> Running: hg svn info >>> Command exited with rc 255: ['hg', 'svn', 'info'] hg: unknown command 'svn' Mercurial Distributed SCM basic commands: add add the specified files on the next commit annotate show changeset information by line for each file clone make a copy of an existing repository commit commit the specified files or all outstanding changes diff diff repository (or selected files) export dump the header and diffs for one or more changesets forget forget the specified files on the next commit init create a new repository in the given directory log show revision history of entire repository or files merge merge another revision into working directory pull pull changes from the specified source push push changes to the specified destination qdiff diff of the current patch and subsequent modifications qnew create a new patch qpop pop the current patch off the stack qpush push the next patch onto the stack qrefresh update the current patch remove remove the specified files on the next commit serve start stand-alone webserver status show changed files in the working directory summary summarize working directory state update update working directory (or switch revisions) (use "hg help" for the full list of commands or "hg -v" for details) --- >>> Using candidate path 'default': u'ssh://hg.nasuni.net/hg/unity' >>> repository info: Path: ssh://hg.nasuni.net/hg/unity, Base path: , Supports >>> changesets: False >>> Making HTTP GET request to http://codereview.nasuni.net/api/ >>> Running: hg branch >>> Running: hg -q outgoing --template {rev}\t{node|short}\t{branch}\n default >>> -r . >>> Found outgoing changeset 81925:109217a2670d >>> Running: hg log -r 81925 --template {parents} >>> Running: hg parents --hidden -r 0 >>> Running: hg identify -i --hidden -r 81924 --config >>> extensions.rbtoolsnormalize=/usr/local/lib/python2.7/dist-packages/RBTools-0.7.4-py2.7.egg/rbtools/helpers/hgext.py >>> Running: hg identify -i --hidden -r 81925 --config >>> extensions.rbtoolsnormalize=/usr/local/lib/python2.7/dist-packages/RBTools-0.7.4-py2.7.egg/rbtools/helpers/hgext.py >>> Running: hg status --modified --added --removed --deleted >>> Running: hg -q outgoing --template {rev}\t{node|short}\t{branch}\n default >>> -r a49b7edd2ba7 >>> Command exited with rc 1: ['hg', '-q', 'outgoing', '--template', >>> '{rev}\\t{node|short}\\t{branch}\\n', 'default', '-r', u'a49b7edd2ba7'] --- >>> 0 outgoing changesets between remote and base. >>> Running: hg diff --hidden -r a49b7edd2ba7 -r 109217a2670d --config >>> extensions.rbtoolsnormalize=/usr/local/lib/python2.7/dist-packages/RBTools-0.7.4-py2.7.egg/rbtools/helpers/hgext.py >>> Running: hg locate -r a49b7edd2ba7 >>> Running: hg locate -r 109217a2670d >>> Running: hg locate -r 109217a2670d set:size(0) >>> Running: hg locate -r a49b7edd2ba7 set:size(0) diff --git a/python/rbttest.py b/python/rbttest.py new file mode 100644 --- /dev/null +++ b/python/rbttest.py @@ -0,0 +1,1 @@ +#This is a test.
