Hi Christian, We were wondering if you guys were making any progress on this issue.
Thanks, John On Thursday, December 22, 2016 at 10:13:42 AM UTC-5, John wrote: > > Thanks Christian. Review Board is a great tool and we enjoy its ease of > use. We look forward to being able to get around this hurdle in the > future. Again, let us know if you need anything else from our end. > > -John > > > On Wednesday, December 21, 2016 at 10:41:20 PM UTC-5, Christian Hammond > wrote: >> >> Thanks, John! We'll try to figure out what's going on. Already seeing a >> few things wrong with the diff, which may clue us in to the source of the >> problem. We'll try to get this fixed and get back to you after the holidays. >> >> Christian >> >> On Wed, Dec 21, 2016 at 10:52 John <[email protected]> wrote: >> >>> >>> >>> On Monday, December 19, 2016 at 5:10:15 PM UTC-5, John wrote: >>>> >>>> We are using mercurial in our environment and for some reason we are >>>> seeing a number of __init__.py (blank files for module inclusion in >>>> python) >>>> are being added to our diff file. Here is the process we used to >>>> reproduce >>>> the issue: >>>> >>>> 1. Clone a branch in the repo. >>>> 2. create a new file with some text in it (i.e. mytestfile.py). >>>> 3. Add a new file in the repo with "hg add mytestfile.py" >>>> 4. hg commit -m "This is a test" ./mytestfile.py >>>> 5. rbt post >>>> >>>> >>>> Here is what the diff of the new file looks like with a simple "hg >>>> diff" before running commit: >>>> >>>> diff --git a/python/tools/mytestfile.py b/python/tools/mytestfile.py >>>> new file mode 100644 >>>> --- /dev/null >>>> +++ b/python/mytestfile.py >>>> @@ -0,0 +1,1 @@ >>>> +print "This is a test" >>>> >>>> Attached please find the diff that was downloaded from Review Board. >>>> >>>> What you'll find is that the diff for the new file that was added does >>>> make it up there but for some reason ~50+ __init__.py files are also >>>> removed and then added to the diff. It causes the review request to look >>>> very messy. The diff file I added was downloaded directly from review >>>> board and then I snipped the end of it so the file wouldn't be too large. >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >>> -- >>> >>> >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> >>> >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> >>> >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> >>> >>> --- >>> >>> >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> >>> >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >>> >>> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
