Chris Lamb:
Hi Niels,I am not sure why this happened because at first glance, the `gettext.pm` handler does seem to the correct guards in place.As you imply, the "Normalizing da.mo" message is highly misleading: it's printed *before* calling the normalizer in all cases, and simply denotes that we are just about to call into the format-specific code. I'll change it to "Calling normalizer for $filename" shortly.Nevertheless, it must be returning a truth value, since the message appears.Contrary to what you write here, the normalizer is not returning a truth value for da.mo — see my previous paragraph. Of course, it is understandable you thought this given the message is, as you write, rather misleading. :) The main question that remains is whether there is anything in da.mo that should be normalized. If there is, then there is an additional bug in the normalizer (and not just the bug in the phrasing of the message). Regards,
Ok. I was confused because `dh_strip_nondeterminism` has two messages here. One for "Normalizing ... using ..." and one for "Normalized ..." (vs. "Normalizing ..." from `strip-nondeterminism` that matches the "first" case without naming the normalizer).
I would like the same behavior from `strip-nondeterminism`, so you can tell which files were actually modified (normalized) like you can with `dh_strip_nondeterminism`).
I would see the "Normalized ..." case as being on by default (without needing `--verbose`) and "Normalizing ... [using ...]" or "Calling normalizer for ..." being fine as `--verbose` only.
My reason for asking is that in my work on `debputy`, I cannot use `dh_strip_nondeterminism`. Instead, I invoke `strip-nondeterminism` directly and I would like the feature parity of presenting to the user (including in the buildlog) which files were modified.
Best regards, Niels
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/reproducible-builds
