On 17/08/21 at 09:22 -0700, Vagrant Cascadian wrote: > On 2021-08-17, Mattia Rizzolo wrote: > > On Thu, Aug 12, 2021 at 03:35:05PM +0200, Niels Thykier wrote: > >> > On 2021-08-10 Holger Levsen <holger-Yq+U+nADzX/cAl+TvhycwA at > >> > public.gmane.org> wrote: > >> >> [...] > >> > > >> > Hello, > >> > > >> > Isn't CMAKE_SKIP_RPATH a rather strange choice, what are the expected > >> > benefits over CMAKE_SKIP_INSTALL_RPATH? There is potential for breaking > >> > testsuites. > >> > > >> > Doesn't this break packages that intentionally use rpath for private > >> > shared libraries? > >> > > >> > cu Andreas > >> > >> Hi Andreas, > >> > >> The CMAKE_SKIP_RPATH was recommended in #962474 > >> (https://bugs.debian.org/962474) to improve reproducibility by default. > >> The bug contains the rationale for that option and explains the > >> underlying issue (plus links to the upstream bug tracker where that > >> topic was also discussed). > > > > > > Indeed, -DCMAKE_SKIP_RPATH=ON for me broke things in src:lib2geom: > > https://salsa.debian.org/multimedia-team/lib2geom/-/commit/f8a4c06edbd64d4c77d69ef3aea93e978a7156e4 > > > > this is just an example, and I expect plenty of breakages. > > > > > > May I recommend we do *not* enable this on the r-b builders, as I'm > > positive it would break quite a few things here and there. Rather, it > > would be perfect for aws' comparative rebuilds. Now, who is the > > contact for those these days? > > When we did the dpkg fixfilepath testing last year, Lucas Nussbaum was > the one who handled actually running the tests. I recall having to > submit a pull request against collab-qa-tools: > > https://salsa.debian.org/lucas/collab-qa-tools/-/merge_requests/9 > > Is that still a thing?
Hi, yes, to do a comparative rebuild, I just need such a script that adjusts the build environment to whatever is needed. See other examples in https://salsa.debian.org/lucas/collab-qa-tools/-/tree/master/modes I have a few rebuilds to run and process, and little time for Debian currently, but I'll find the time eventually. Lucas _______________________________________________ Reproducible-builds mailing list Reproducible-builds@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/reproducible-builds
