@gravitystorm commented on this pull request.


> @@ -0,0 +1,5 @@
+class AddShowContributionHeatmapToUsers < ActiveRecord::Migration[7.2]
+  def change
+    add_column :users, :show_contribution_heatmap, :boolean, :default => true, 
:null => false

> * it ok to create a column with a default value in a large table?

We use [strong migrations](https://github.com/ankane/strong_migrations) to 
check that the migrations are safe to run in production. This means that 
contributors don't need to learn all the edge cases, and maintainers don't need 
to know them all either and can merge PRs with confidence if CI is green.

Previously strong migrations would flag this situation for PG < 11, but it now 
supports only PG 12+ and so it [dropped the check last 
year](https://github.com/ankane/strong_migrations/commit/1e428665978185bc3b21a36db723dd91c10b5e12#diff-2c318d74d04a82865bea4780a048a37f4871393db99d20b798eb19516c188104R44-L46)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5853#discussion_r2631459080
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5853/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to